Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currency code settings #64

Merged
merged 2 commits into from
May 23, 2021
Merged

Currency code settings #64

merged 2 commits into from
May 23, 2021

Conversation

nafiesl
Copy link
Owner

@nafiesl nafiesl commented May 7, 2021

Description

In this PR, are adding user settings for currency_code. This feature will resolve issue #61.

Checklist

  • Add currency_code column on the users table.
  • Use the current user's Currency Code to replace the Rp labels on the views.
  • Currency Code is a string with 3 characters maximum (ref: https://www.iban.com/currency-codes).
  • Use IDR as the default currency_code value of the users table.

How to test on localhost

  1. Checkout to the branch
$ git fetch origin
$ git checkout currency_code_settings
  1. Run artisan migrate
$ php artisan migrate
  1. Run local server
$ php artisan serve
  1. Open the web http://127.0.0.1:8000
  2. Try to change the currency setting on the user profile page with 3 character letters.
  3. Open transaction entry form, we should see the currency code shown on the transaction amount field.

Screenshots

The User profile page

screen_2021-05-07_004

The Transaction form

screen_2021-05-07_003

@nafiesl nafiesl marked this pull request as ready for review May 23, 2021 13:37
@nafiesl nafiesl merged commit 2c1bb66 into master May 23, 2021
@nafiesl nafiesl deleted the currency_code_settings branch May 23, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant